php - Best way to organize parameters when adding your own asserts to phpUnit -


almost of phpunit asserts 3 parameters:

  1. expected result
  2. actual value
  3. optional message print on failure

(some, such asserttrue(), have implicit expected result, have 2 parameters.)

but, if expected result not clean? may optional parameters, or may there more test 1 value. 1 concrete example, have asserttimestamp($expected_time,$actual_time,$tolerance=0,$msg='') tolerance allows bit of clock drift. (i use test created timestamp in database, assert record created in last 30 seconds, i.e. previous function in current unit test run.)

does reasonable? i.e. push $msg end, , keep actual second parameter. asserttag has ishtml flag, comes last, after $msg.

as more complex example i've function takes json string $actual parameter. runs json_decode, extracts few values, , checks each of them. have this: 

function assertjsonpersonfromdbresponse($name,$gender,$age,$actual,$expectsomething=false,$msg='')

would differently? wondering if might better squeeze expected parameters (including optional flags) first parameter, associative array:

function assertjsonpersonfromdbresponse($expected,$actual,$msg='') ... $this->assertjsonpersonfromdbresponse(array('name'=>'darren','age'=>21,     'gender'=>'m','expectsomething'=>true),$s);

that feels cleaner. there existing convention these kind of situations?

the pattern see throught phpunit code base is:

[$expected (if needed)], $actual, $message = '', [other optional paramters]

for exaples take @ framework/assert.php file

public static function assertequals(     $expected,      $actual,      $message = '',      $delta = 0,      $maxdepth = 10,      $canonicalize = false,      $ignorecase = false )

or more precisce since $actual can composed of more 1 variable (class & attribute example):

[$allexpectedparamsifneeded], $allactualparams, $message='', [$allotherswitches]

for example:

public static function assertattributeinternaltype(     $expected,     $attributename,     $classorobject,     $message = '' )

or

public static function assertselectregexp(     $selector,     $pattern,     $count,     $actual,     $message = '',     $ishtml = true )

general advice assertions:

try minimize amount of parameters , use more assert functions if possible:

$this->assertstuff($a, $b, true, false, 'oh dear', 6, true);

is not readable , confusing me.

having

$this->assertstuffforspecificcasewithsubcasesix($a, $b, 'oh dear');

at least "inline documentation" @ every place it's used.


Comments

Post a Comment

Popular posts from this blog

java - Play! framework 2.0: How to display multiple image? -

i need display gallery of photos. here template: @(photos: list[photo]) @title = { <bold>gallery</bold> } @main(title,"photo"){ <ul class="thumbnails"> @for(photo <- photos) { <li class="span3"> <a href="#" class="thumbnail"> <img src="@photo.path" alt=""> </a> </li> } </ul> } and here controller method: public static result getphotos() { return ok(views.html.photo.gallery.render(photo.get())); } and here photo bean : @entity public class photo extends model { @id public long id; @required public string label; public string path; public photo(string path, string label) { this.path = path; this.label = label; } private static finder<long, photo> find = new finder<long, photo>( long.class, photo.class); public static list<phot...
Read more

gmail - Is there any documentation for read-only access to the Google Contacts API? -

i want read-only access user's google contacts. there stackoverflow member wanted this, , received following answer : yes, there is, use https://www.googleapis.com/auth/contacts.readonly scope , "view contacts". this exchange reference read-only access google contacts can find using google. simply using access token obtained attempt read usual google contacts api (i.e. https://www.google.com/m8/feeds ) fails insufficient permissions. similarly, using google contacts api on new target fails 404 errors (for example https://www.googleapis.com/auth/contacts.readonly/default/full ). is there documentation anywhere on how use api, or permissible way access google contacts api full read-write access?
Read more

php - Controller/JToolBar not working in Joomla 2.5 -

relevant code: jtoolbarhelper::custom('savecategories', 'save', '', 'save', false, false); ... <input type="hidden" name="controller" value="easyblogcontroller"> according can dig docs , own previous questions, should call savecategories() function in easyblogcontroller . i've tried setting value easyblog , easyblog.php (file name) current easyblogcontroller (class name). clicking on save button refreshes page. not redirect, echo or var_dump test code put in savecategories() function. var_dump ing jrequest::getvar('controller') , 'task' return correct values. creating controller object , using $controller->execute('task'); works. the values going depend on location of controller trying call, , have couple options here. typically there controller in base folder of component (likely components/com_easyblog) in file called controller.php , class name inside ...
Read more