php - Standards for exiting a function -


possible duplicate:
why should function have 1 exit-point?

as cs student have had beaten head there should 1 exit point in function, @ end.

eg. this:

function foo() {      //do stuff here      if($bar)     {          $out = false;     }     else     {          $out = true;     }     return $out; }

not:

function foo() {      //do stuff here      if($bar)     {          return false;     }     return true; }

however have seen second type of exiting used quite in other peoples code in php, , in core code frameworks (like kohana have been using lately). method of exiting function considered okay in php standards?

edit: can see why have been told not can easier track problems in function 1 exit point, other times can see why should allowed other problems better solved or tracked in functions multiple exit points.

edit 2: added "do stuff here" comments code example make people happy

i've used latter route, since have declare $out , have 1 more variable in existence. in retrospect, it's boolean -- it's not doing harm. first route cleaner, depending on context of code.

it comes down consistency. long have system, determining when time use route 1 or route 2, you're doing great.


Comments

Post a Comment

Popular posts from this blog

java - Play! framework 2.0: How to display multiple image? -

i need display gallery of photos. here template: @(photos: list[photo]) @title = { <bold>gallery</bold> } @main(title,"photo"){ <ul class="thumbnails"> @for(photo <- photos) { <li class="span3"> <a href="#" class="thumbnail"> <img src="@photo.path" alt=""> </a> </li> } </ul> } and here controller method: public static result getphotos() { return ok(views.html.photo.gallery.render(photo.get())); } and here photo bean : @entity public class photo extends model { @id public long id; @required public string label; public string path; public photo(string path, string label) { this.path = path; this.label = label; } private static finder<long, photo> find = new finder<long, photo>( long.class, photo.class); public static list<phot...
Read more

gmail - Is there any documentation for read-only access to the Google Contacts API? -

i want read-only access user's google contacts. there stackoverflow member wanted this, , received following answer : yes, there is, use https://www.googleapis.com/auth/contacts.readonly scope , "view contacts". this exchange reference read-only access google contacts can find using google. simply using access token obtained attempt read usual google contacts api (i.e. https://www.google.com/m8/feeds ) fails insufficient permissions. similarly, using google contacts api on new target fails 404 errors (for example https://www.googleapis.com/auth/contacts.readonly/default/full ). is there documentation anywhere on how use api, or permissible way access google contacts api full read-write access?
Read more

php - Controller/JToolBar not working in Joomla 2.5 -

relevant code: jtoolbarhelper::custom('savecategories', 'save', '', 'save', false, false); ... <input type="hidden" name="controller" value="easyblogcontroller"> according can dig docs , own previous questions, should call savecategories() function in easyblogcontroller . i've tried setting value easyblog , easyblog.php (file name) current easyblogcontroller (class name). clicking on save button refreshes page. not redirect, echo or var_dump test code put in savecategories() function. var_dump ing jrequest::getvar('controller') , 'task' return correct values. creating controller object , using $controller->execute('task'); works. the values going depend on location of controller trying call, , have couple options here. typically there controller in base folder of component (likely components/com_easyblog) in file called controller.php , class name inside ...
Read more